[Webkit-unassigned] [Bug 34633] WebSocket bufferedAmount should not be 0 when send after close.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 17:37:25 PST 2010


--- Comment #10 from Fumitoshi Ukai <ukai at chromium.org>  2010-02-17 17:37:25 PST ---
(In reply to comment #9)
> (From update of attachment 48737 [details])
> +                if (frameByte == 0x00 && !m_client)
>                      m_client->didReceiveMessage(String::fromUTF8(msgStart, p -
> msgStart));
> The check is backwards (should be m_client, not !m_client). Did you run
> regression tests with this change? If no test detects such a mistake, we should
> try to make one that does.

Oops. Thanks for catching this.

> Also, do we even need to continue parsing when m_client becomes null? It seems
> that an early return would be a better solution.

Ok, I add check !m_client after it calls m_client methods, because it calls
user callback, user callback may call close() and onclose handler would set
m_client = 0.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list