[Webkit-unassigned] [Bug 34633] WebSocket bufferedAmount should not be 0 when send after close.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34633


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48737|review?                     |review-
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2010-02-17 10:07:47 PST ---
(From update of attachment 48737)
+                if (frameByte == 0x00 && !m_client)
                     m_client->didReceiveMessage(String::fromUTF8(msgStart, p -
msgStart));

The check is backwards (should be m_client, not !m_client). Did you run
regression tests with this change? If no test detects such a mistake, we should
try to make one that does.

Also, do we even need to continue parsing when m_client becomes null? It seems
that an early return would be a better solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.