[Webkit-unassigned] [Bug 32724] [Qt] It should be possible to disable inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32724





--- Comment #16 from Ismail "cartman" Donmez <ismail at namtrac.org>  2010-02-16 02:07:54 PST ---
(In reply to comment #15)
> (From update of attachment 48795 [details])
> >  
> >  static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer)
> >  {
> > +#if !ENABLE(INSPECTOR)
> > +    return 0;
> > +#else
> >      Frame* frame = renderer->document()->frame();
> >      if (!frame)
> >          return 0;
> > @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer)
> >      if (!page)
> >          return 0;
> >      return page->inspectorTimelineAgent();
> > +#endif
> >  }
> 
> 
> You should just surround this entire method with if ENABLE(INSPECTOR). Please
> fix this before landing.

Since I cannot land myself anyway, if I just surround with if ENABLE(INSPECTOR)
it would give a compiler warning/error saying the function should return a
value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.