[Webkit-unassigned] [Bug 32724] [Qt] It should be possible to disable inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32724


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48795|review?                     |review+
               Flag|                            |




--- Comment #15 from Pavel Feldman <pfeldman at chromium.org>  2010-02-16 02:05:49 PST ---
(From update of attachment 48795)
>  
>  static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer)
>  {
> +#if !ENABLE(INSPECTOR)
> +    return 0;
> +#else
>      Frame* frame = renderer->document()->frame();
>      if (!frame)
>          return 0;
> @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer)
>      if (!page)
>          return 0;
>      return page->inspectorTimelineAgent();
> +#endif
>  }


You should just surround this entire method with if ENABLE(INSPECTOR). Please
fix this before landing.

>  
>  // Up-call from compositing layer drawing callback.
> diff --git a/WebKit/qt/Api/qwebpage.cpp b/WebKit/qt/Api/qwebpage.cpp
> index 185a2ee..256d6c4 100644
> --- a/WebKit/qt/Api/qwebpage.cpp
> +++ b/WebKit/qt/Api/qwebpage.cpp
> @@ -163,27 +163,42 @@ QString QWEBKIT_EXPORT qt_webpage_groupName(QWebPage* page)
>  
>  void QWEBKIT_EXPORT qt_drt_webinspector_executeScript(QWebPage* page, long callId, const QString& script)
>  {

Nit: In case these are only used from within DRT, should you hide these methods
as well and use guards in layout test controller instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.