[Webkit-unassigned] [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34382


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48605|0                           |1
        is obsolete|                            |
  Attachment #48680|                            |review?, commit-queue-
               Flag|                            |




--- Comment #31 from Dmitry Titov <dimich at chromium.org>  2010-02-12 16:47:16 PST ---
Created an attachment (id=48680)
 --> (https://bugs.webkit.org/attachment.cgi?id=48680)
Updated according to comments.

I think I've got all comments in. Changes:

- [Qt] webPageChanged -> pageChanged and moved page setting code into
setPage(), as requested.
- [Qt] realized that main frame has QWebPage as QObject parent, while child
frames have their parent's QWebFrames as QObject parent - adjusted code for
that.
- [Chromium] - chatted with Darin and removed WebFrameClient notification until
the time we realize we need it.
- FrameLoaderClient::didTransferChildFrameToNewDocument lost "Document*"
parameter, since the new document can always be pulled from frame.
- test did not change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.