[Webkit-unassigned] [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34382





--- Comment #30 from Dmitry Titov <dimich at chromium.org>  2010-02-12 10:08:42 PST ---
(In reply to Darin Fisher's comment #27)

I don't think I phrased my response well. Here is another attempt:

I agree the transferChildFrameToNewDocument() seems to do more then its name
says. For example, it recurses into children, while they do not get transferred
to a new document.

Perhaps the better way would be to split out the recursive Frame::setPage(Page
newPage) which would set Page pointer in a frame subtree and call it from
transferChildFrameToNewDocument. Then, add a loop in Chromium's
FrameLoaderClientImpl::didTransferChildFrameToNewDocument to update client
pointers, as you suggested. This way, each function will do what it names
says...

Separately, we might remove WebFrameClient external notification until the
moment we'll actually need an implementation of it - it may give us better
understanding what parameters it needs at that time.

Do you think it's a reasonable plan?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.