[Webkit-unassigned] [Bug 34812] [Android] SVG code in V8 bindings is not properly guarded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 16:12:39 PST 2010


--- Comment #6 from Steve Block <steveblock at google.com>  2010-02-10 16:12:36 PST ---
> I see what you are saying. I though the idl typically had the correct guard
> specified, so the header is generated with the appropriate if ENABLE.
Yes, I think they should be generated with the appropriate guard.

> But you're right that this means the header is generated when it doesn't need
> to be.  If at all possible, I think that is better than adding extra clutter to
> the files.
OK, I'll update the patch to not guard the include sites, and will make sure
the generated headers include the guards.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list