[Webkit-unassigned] [Bug 34812] [Android] SVG code in V8 bindings is not properly guarded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34812





--- Comment #5 from David Levin <levin at chromium.org>  2010-02-10 15:59:31 PST ---
(In reply to comment #4)
> >   #if ENABLE(SVG) 
> > to exclude headers should be removed. The headers themselves should have the if
> > inside of them.
> Is that also the case for generated headers? Having the guard around the
> include site means that generated headers for unsupported features don't need
> to be built.

I see what you are saying. I though the idl typically had the correct guard
specified, so the header is generated with the appropriate if ENABLE.

But you're right that this means the header is generated when it doesn't need
to be.  If at all possible, I think that is better than adding extra clutter to
the files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.