[Webkit-unassigned] [Bug 34777] [Qt] Make possible Qt DRT get a page number for element by ID

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34777





--- Comment #6 from Diego Gonzalez <diego.gonzalez at openbossa.org>  2010-02-10 05:09:00 PST ---
(In reply to comment #5)
> (From update of attachment 48487 [details])
> 
> >  
> > +int QWEBKIT_EXPORT qt_drt_pageNumberForElementById(QWebFrame* qFrame, const QString& id, float width, float height)
> > +{
> > +    Frame* frame = QWebFramePrivate::core(qFrame);
> > +    if (!frame)
> 
> I would have used frame and coreFrame :-)

humm I just followed the pattern of the others qt_drt*

> > +int LayoutTestController::pageNumberForElementById(const QString& id, float width, float height)
> > +{
> > +    // If no size specified, webpage viewport size is used
> > +    if (!width && !height) {
> > +        width = m_drt->webPage()->viewportSize().width();
> > +        height = m_drt->webPage()->viewportSize().height();
> > +    }
> 
> What is with is 0, but height is not?

I assumed the method will calculate using 0 for width and a given value for
height, and it will possibly return a invalid value for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.