[Webkit-unassigned] [Bug 34777] [Qt] Make possible Qt DRT get a page number for element by ID

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34777


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48487|review?                     |review+
               Flag|                            |




--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-10 04:55:31 PST ---
(From update of attachment 48487)

>  
> +int QWEBKIT_EXPORT qt_drt_pageNumberForElementById(QWebFrame* qFrame, const QString& id, float width, float height)
> +{
> +    Frame* frame = QWebFramePrivate::core(qFrame);
> +    if (!frame)

I would have used frame and coreFrame :-)
> +int LayoutTestController::pageNumberForElementById(const QString& id, float width, float height)
> +{
> +    // If no size specified, webpage viewport size is used
> +    if (!width && !height) {
> +        width = m_drt->webPage()->viewportSize().width();
> +        height = m_drt->webPage()->viewportSize().height();
> +    }

What is with is 0, but height is not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.