[Webkit-unassigned] [Bug 51755] [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51755





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-12-30 15:53:28 PST ---
(From update of attachment 77687)
View in context: https://bugs.webkit.org/attachment.cgi?id=77687&action=review

Thanks for the review!

>> WebCore/ChangeLog:105
>> +
> 
> Either remove all that stuff or fill in the details?

Okay. Will remove this.

>> WebCore/platform/gtk/RenderThemeGtk.cpp:456
>> +                   gtkTextDirection(renderObject->style()->direction()),
> 
> This is somewhat random :D (I believe in general adding extra newlines goes against the style guidelines?)

Oh right. This is unrelated. If a line is longer than 100 or 120 characters it's generally okay to break it though. I will remove this change though.

>> WebCore/platform/gtk/RenderThemeGtk3.cpp:156
>> +#endif
> 
> This is always going to be FALSE for GTK+ 3.x right?

Yep. I'll remove this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.