[Webkit-unassigned] [Bug 51755] [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51755





--- Comment #4 from Xan Lopez <xan.lopez at gmail.com>  2010-12-30 15:38:06 PST ---
(From update of attachment 77687)
View in context: https://bugs.webkit.org/attachment.cgi?id=77687&action=review

> WebCore/ChangeLog:105
> +

Either remove all that stuff or fill in the details?

> WebCore/platform/gtk/RenderThemeGtk.cpp:456
> +                   gtkTextDirection(renderObject->style()->direction()),

This is somewhat random :D (I believe in general adding extra newlines goes against the style guidelines?)

> WebCore/platform/gtk/RenderThemeGtk3.cpp:156
> +#endif

This is always going to be FALSE for GTK+ 3.x right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.