[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116





--- Comment #34 from Eric Seidel <eric at webkit.org>  2010-12-27 17:35:05 PST ---
(In reply to comment #32)
> (In reply to comment #30)
> > It's a little odd to have a HAVE definition outside of Platform.h no?
> 
> Sure, it would be OK to move that logic to Platform.h.
> 
> On the one hand, I am not sure that it's good to continue making that an everything file, but it would be good to put language and compiler things all in one place, although I don’t think there’s a good clear purpose to that file at the moment. It doesn't make sense to me that the platform independence macros are in the same file as their definitions for all platforms.

Yeah.  It's unfortunate that Platform.h has all of these, however the way the current HAVE() macro works, if a HAVE_ is not defined then it's assumed false:
#define HAVE(WTF_FEATURE) (defined HAVE_##WTF_FEATURE  && HAVE_##WTF_FEATURE)

Which could lead to folks compiling things in ways they didn't intend if all the HAVE_ definitions aren't in one place.

> I think Maciej designed a new way to do it.

Unfortunately he's been saying that for years. :)  I'm looking forward to it though!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.