[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116





--- Comment #33 from Jake <jake at jakeonthenet.com>  2010-12-27 16:16:57 PST ---
Thanks Darin! I'll get latest and do a new build.

-Jake

(In reply to comment #32)
> (In reply to comment #30)
> > It's a little odd to have a HAVE definition outside of Platform.h no?
> 
> Sure, it would be OK to move that logic to Platform.h.
> 
> On the one hand, I am not sure that it's good to continue making that an everything file, but it would be good to put language and compiler things all in one place, although I don’t think there’s a good clear purpose to that file at the moment. It doesn't make sense to me that the platform independence macros are in the same file as their definitions for all platforms. I think Maciej designed a new way to do it.
> 
> Anyway, moving would be fine with me.
> 
> Other files defining HAVE outside Platform.h include Assertions.h, RenderObject.h and GraphicsContextCG.cpp.
> 
> > I guess any code which wants to actually use nullptr_t will have to include NullPtr.h anyway.
> 
> Yes, that's what I was thinking.

(In reply to comment #29)
> Jake, I took the liberty of reworking your patch and landing it.
> 
> Since I didn't actually compile with Visual Studio 2010, there may still be some ambiguous operator= problems, or other problems. I suggest new separate bug reports for individual remaining problems. Please feel free to cc me on any of those bugs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.