[Webkit-unassigned] [Bug 51490] Cleanup SVG code according to the webkit style rules 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51490





--- Comment #15 from Dirk Schulze <krit at webkit.org>  2010-12-27 10:48:23 PST ---
(In reply to comment #14)
> (From update of attachment 77509 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77509&action=review
> 
> Still needs some tweaks, r-.
> 
> > WebCore/ChangeLog:11
> > +        * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
> > +        * SVGImage.cpp: One header needs to be in a non-alphabetic order, see FIXME.
> 
> Do you know about the "NOLINT" comment.
No, didn't know this. But I'd add this after every line on SVGGAllInOne, not the best choice. But it helps on SVGImage. Do you have another suggestion?

> > WebCore/svg/animation/SVGSMILElement.cpp:800
> > -        if (fmod(repeatingDuration.value(), simpleDuration.value() == 0.))
> > +        if (fmod(repeatingDuration.value(), !simpleDuration.value()))
> 
> Is this correct??
Checked it, it is correct. The operator ! just checks if value is finite as well, doesn't influence the result.

The rest is fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.