[Webkit-unassigned] [Bug 51490] Cleanup SVG code according to the webkit style rules 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51490


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77509|review?                     |review-
               Flag|                            |




--- Comment #14 from Nikolas Zimmermann <zimmermann at kde.org>  2010-12-27 10:04:02 PST ---
(From update of attachment 77509)
View in context: https://bugs.webkit.org/attachment.cgi?id=77509&action=review

Still needs some tweaks, r-.

> WebCore/ChangeLog:11
> +        * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
> +        * SVGImage.cpp: One header needs to be in a non-alphabetic order, see FIXME.

Do you know about the "NOLINT" comment.
int _I_want_to_violate_the_style_result; // NOLINT
This suppresses the error message from check-webkit-style. I guess you can make check-webkit-style happy when playing around with this comment, to make it report 0 errors for svg/.

> WebCore/svg/SVGSwitchElement.cpp:50
> +        if (node->isSVGElement()) {

if (!node->isSVGElement())
    continue;

> WebCore/svg/SVGSwitchElement.cpp:52
>              if (element && element->isValid())

if (!element || !element->isValid())
    continue;

> WebCore/svg/SVGSwitchElement.cpp:53
> +                return (node == child); // Only allow this child if it's the first valid child

return node == child.

> WebCore/svg/SVGTransformDistance.cpp:240
> +    return m_transform == AffineTransform() && !m_angle;

m_transform.isIdentity() ?

> WebCore/svg/animation/SVGSMILElement.cpp:800
> -        if (fmod(repeatingDuration.value(), simpleDuration.value() == 0.))
> +        if (fmod(repeatingDuration.value(), !simpleDuration.value()))

Is this correct??

> WebCore/svg/animation/SVGSMILElement.h:60
> +    enum Restart { RestartAlways, RestartWhenNotActive, RestartNever };

I think these should be
enum Restart {
    RestartAlways,
     .....
}

> WebCore/svg/animation/SVGSMILElement.h:63
> +    enum FillMode { FillRemove, FillFreeze };

Ditto.

> WebCore/svg/animation/SVGSMILElement.h:107
> +    enum BeginOrEnd { Begin, End };

enum BeginOrEnd {
    Begin,
    End
};

> WebCore/svg/animation/SVGSMILElement.h:122
> +        enum Type { EventBase, Syncbase, AccessKey };

Ditto, needs reformatting.

> WebCore/svg/animation/SVGSMILElement.h:150
> +    enum ActiveState { Inactive, Active, Frozen };

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.