[Webkit-unassigned] [Bug 51569] [GTK] EditorClient::generateEditorCommands queues up "null string" commands

Sun Dec 26 15:32:00 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=51569

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77454|review?                     |review+
               Flag|                            |

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-26 15:32:00 PST ---
(From update of attachment 77454)
View in context: https://bugs.webkit.org/attachment.cgi?id=77454&action=review

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:666
> +     if (!mapKey)

When is this condition ever true?  I would have put an assertion here unless you know a condition in which map key is 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.