[Webkit-unassigned] [Bug 51569] [GTK] EditorClient::generateEditorCommands queues up "null string" commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51569





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-12-26 14:29:57 PST ---
(In reply to comment #2)
> How do we test this?

Recently a null command string would cause an assertion failure deeper in the editing code on many tests (> 20 crashes on the debug build before it ).

In this patch, I added an assertion in the WebKitGTK+ specific code which ensures that no null editing command strings are generated. If this ever starts failing again, many tests will start hitting this assertion and show crashes on the bots. 

If this isn't sufficient, it will be pretty easy to create a test that verifies this. All keystrokes that don't result in an editor command were generating a null command string, which is why so many tests will start crashing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.