[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116





--- Comment #21 from Jake <jake at jakeonthenet.com>  2010-12-24 14:21:18 PST ---
(In reply to comment #20)
> (From update of attachment 77388 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77388&action=review
> 
> Thanks for the patch!
> 
> > WebCore/dom/Document.cpp:3175
> > +            newFocusedNode = (Node*) 0;
> 
> We don't use c-style casts.  Why is this code modifying the PassRefPTr anyway?  We can call .clear() instead, I think?
> 
> > WebCore/dom/ViewportArguments.h:77
> > +        , userScalable((bool) ValueAuto)
> 
> Again, we don't use c-style casts.  We should either disable the failing warning for the file, or we should use static_cast or find some better way to avoid the error.

I have no idea whether .clear() can be called - I didn't write the code. All I know is newFocusedNode = 0; doesn't compile.

And secondly, userScalable(ValueAuto) is far worse than the cast - at least with the cast its clear what is going on - userScalable is a bool and ValueAuto isn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.