[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77388|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #20 from Eric Seidel <eric at webkit.org>  2010-12-24 08:58:57 PST ---
(From update of attachment 77388)
View in context: https://bugs.webkit.org/attachment.cgi?id=77388&action=review

Thanks for the patch!

> WebCore/dom/Document.cpp:3175
> +            newFocusedNode = (Node*) 0;

We don't use c-style casts.  Why is this code modifying the PassRefPTr anyway?  We can call .clear() instead, I think?

> WebCore/dom/ViewportArguments.h:77
> +        , userScalable((bool) ValueAuto)

Again, we don't use c-style casts.  We should either disable the failing warning for the file, or we should use static_cast or find some better way to avoid the error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.