[Webkit-unassigned] [Bug 50770] [GStreamer] PlatformVideoWindowMac implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50770





--- Comment #4 from Philippe Normand <pnormand at igalia.com>  2010-12-20 05:34:59 PST ---
(In reply to comment #3)
> (From update of attachment 76096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76096&action=review
> 
> I won't r+ this because I don't know enough about the gstreamer portion to tell if it is correct or not.
> 
> 
> > WebCore/ChangeLog:17
> > +        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
> > +        (WebCore::gstGWorldSyncMessageCallback):
> > +        * platform/graphics/gstreamer/PlatformVideoWindowMac.mm: Added.
> > +        (PlatformVideoWindow::PlatformVideoWindow):
> > +        (PlatformVideoWindow::~PlatformVideoWindow):
> > +        (PlatformVideoWindow::prepareForOverlay):
> > +
> 
> Looks like you forgot to add PlatformVideoWindowMac.h
> 
> 

The generic PlatformVideoWindow.h header can be used. This is just the platform-specific implementation.

> > WebCore/platform/graphics/gstreamer/PlatformVideoWindowMac.mm:40
> > +PlatformVideoWindow::PlatformVideoWindow()
> > +{
> > +    m_window = [[NSView alloc] init];
> > +    m_videoWindowId = reinterpret_cast<unsigned long>(m_window);
> > +}
> > +
> > +PlatformVideoWindow::~PlatformVideoWindow()
> > +{
> > +    [m_window release];
> > +    m_window = 0;
> > +    m_videoWindowId = 0;
> > +}
> 
> m_window should be a RetainPtr.

Hum but that's specific to the mac platform. m_window is declared in the PlatformVideoWindow.h header, I could define it differently on mac I guess.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.