[Webkit-unassigned] [Bug 50770] [GStreamer] PlatformVideoWindowMac implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50770





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2010-12-16 09:17:59 PST ---
(From update of attachment 76096)
View in context: https://bugs.webkit.org/attachment.cgi?id=76096&action=review

I won't r+ this because I don't know enough about the gstreamer portion to tell if it is correct or not.


> WebCore/ChangeLog:17
> +        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
> +        (WebCore::gstGWorldSyncMessageCallback):
> +        * platform/graphics/gstreamer/PlatformVideoWindowMac.mm: Added.
> +        (PlatformVideoWindow::PlatformVideoWindow):
> +        (PlatformVideoWindow::~PlatformVideoWindow):
> +        (PlatformVideoWindow::prepareForOverlay):
> +

Looks like you forgot to add PlatformVideoWindowMac.h


> WebCore/platform/graphics/gstreamer/PlatformVideoWindowMac.mm:40
> +PlatformVideoWindow::PlatformVideoWindow()
> +{
> +    m_window = [[NSView alloc] init];
> +    m_videoWindowId = reinterpret_cast<unsigned long>(m_window);
> +}
> +
> +PlatformVideoWindow::~PlatformVideoWindow()
> +{
> +    [m_window release];
> +    m_window = 0;
> +    m_videoWindowId = 0;
> +}

m_window should be a RetainPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.