[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 09:44:01 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50635





--- Comment #12 from Philippe Normand <pnormand at igalia.com>  2010-12-13 09:44:00 PST ---
(In reply to comment #11)
> (From update of attachment 76377 [details])
> I assume you ran the unittests for this. If not, please make sure to do so before committing.
> 

Yes I did check that before sending the patch for review.

> Also, it would be nice if you could add a test for this case. The closest thing I could find was test_precedence, but that doesn't test the case of a file being listed without it's parent directory also being listed. Minor edge case, but more tests make me feel safer. :)

Hum now I figured out my patch should rely on port's filesystem API :) Will send a new patch with a test!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list