[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76377|review?                     |review+
               Flag|                            |




--- Comment #11 from Ojan Vafai <ojan at chromium.org>  2010-12-13 08:31:32 PST ---
(From update of attachment 76377)
I assume you ran the unittests for this. If not, please make sure to do so before committing.

Also, it would be nice if you could add a test for this case. The closest thing I could find was test_precedence, but that doesn't test the case of a file being listed without it's parent directory also being listed. Minor edge case, but more tests make me feel safer. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.