[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635





--- Comment #7 from Philippe Normand <pnormand at igalia.com>  2010-12-12 02:35:09 PST ---
(In reply to comment #6)
> 
> How did you perf test this?  How much speedup did you see?
> 

This is easy to perf :) Just try new-run-webkit-tests --platform=gtk with and without the patch. We (Alexg and I) profiled this with the python hotshot profiler.

Without the patch parsing the expectations takes about 20 seconds here and with the patch less than 2 seconds.

> > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:723
> > +        if not os.path.isfile(path):
> 
> I guess I would have reversed this if to be positive instead of negative.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:725
> > +            result = [ test for test in self._full_test_list if test.startswith(path) ]
> 
> I don't think PEP8 says we put extra spaces around [ ] like this.

OK I can fix those. Thanks for the review

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.