[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75825|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-12-12 02:23:09 PST ---
(From update of attachment 75825)
View in context: https://bugs.webkit.org/attachment.cgi?id=75825&action=review

Well, instead this causes us to stat the file system for each path.  I guess we're doing so right above, so the inode should be cached...

Would this be faster/just as fast if we just compiled a regexp for the path first?

How did you perf test this?  How much speedup did you see?

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:723
> +        if not os.path.isfile(path):

I guess I would have reversed this if to be positive instead of negative.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:725
> +            result = [ test for test in self._full_test_list if test.startswith(path) ]

I don't think PEP8 says we put extra spaces around [ ] like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.