[Webkit-unassigned] [Bug 33336] webkit-patch rollout should be able to do multi-revision rollouts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 13:23:29 PST 2010


--- Comment #13 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-12-10 13:23:29 PST ---
(In reply to comment #12)
> (From update of attachment 76028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76028&action=review
> >>> WebKitTools/Scripts/webkitpy/tool/commands/download_unittest.py:65
> >>> +        state = command._prepare_state(None, ["rev r122  125  123", "Reason"], None)
> >> 
> >> What's the 'rev' here?
> > 
> > Here I just tested whether somebody tries to give wrong (not numerical) revision numbers. But the 'r122' is maybe enough to test this and we can drop the 'rev' string.
> Who is responsible for erroring out when 'rev' is passed?  It seems that if we're *silently* ignoring bad args like 'r122' that will make it easy to make mistakes.
> Seems we should error out in that case, no?

Yes maybe we should so I will correct this and change the unit test expectation.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list