[Webkit-unassigned] [Bug 33336] webkit-patch rollout should be able to do multi-revision rollouts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33336





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-12-10 12:27:54 PST ---
(From update of attachment 76028)
View in context: https://bugs.webkit.org/attachment.cgi?id=76028&action=review

>>> WebKitTools/Scripts/webkitpy/tool/commands/download_unittest.py:65
>>> +        state = command._prepare_state(None, ["rev r122  125  123", "Reason"], None)
>> 
>> What's the 'rev' here?
> 
> Here I just tested whether somebody tries to give wrong (not numerical) revision numbers. But the 'r122' is maybe enough to test this and we can drop the 'rev' string.

Who is responsible for erroring out when 'rev' is passed?  It seems that if we're *silently* ignoring bad args like 'r122' that will make it easy to make mistakes.

Seems we should error out in that case, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.