[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50098





--- Comment #37 from James Kozianski <koz at chromium.org>  2010-12-09 13:49:35 PST ---
(In reply to comment #31)
> (In reply to comment #28)
> > 
> > How about TestOutput? That is probably the most literal name we could have, and it is a bit less ambiguous than just Output.
> > 
> 
> I'm good with TestOutput.
> 
> Aplogies for the delay in responding ... I'm not sure why I didn't see your comments until just now.
> 
> Patch looks pretty good otherwise, although I haven't yet stared at it in detail. It's a bit under-commented for my tastes, but so is the rest of WebKit. Can you either rename one of rebaseline.py or rebaseliner.py or at least add some docs at the top to indicate why there are two files and which is which? Maybe you should just combine them into a single file and/or call the class RebaselineCommand instead of Rebaseline2 ?

I called it rebaseline2 to distinguish it from the current rebaseline command (which is plain Rebaseline). I'll add comments to clarify.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.