[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50098





--- Comment #36 from James Kozianski <koz at chromium.org>  2010-12-09 13:36:44 PST ---
(In reply to comment #34)
> (In reply to comment #33)
> > > WebKitTools/Scripts/webkitpy/tool/commands/rebaseline2/rebaseline2.py:76
> > > +            i = options.use_zip_as_archive.index(':')
> > > +            platform, url = options.use_zip_as_archive[:i], options.use_zip_as_archive[i + 1:]
> > 
> > crazy
> 
> Can you get this with something like options.use_zip_as_archive.index.split(':'), or might there be more than one colon in the value?

It could, depending on what the user names their zips. I remember changing it from .split(':') because I broke something.

> 
> > 
> > > WebKitTools/Scripts/webkitpy/tool/commands/rebaseline2/rebaseline2.py:91
> > > +        del(ports['test'])
> > > +        del(ports['dryrun'])
> > 
> > This doesn't seem scalable.  Can we add something semantic to this port objects so we can know to disregard them?
> >
> 
> This will be fixed as part of bug 47578, which I should be addressing shortly. I wouldn't bother doing anything about it here.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.