[Webkit-unassigned] [Bug 49838] Image Subresource Loads Should Not Prevent Page Cache Entry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49838





--- Comment #19 from Antti Koivisto <koivisto at iki.fi>  2010-12-09 01:09:41 PST ---
(In reply to comment #18)
> That is very good to know! However, in those cases (where the loaders do not
> show up in m_subresourceLoaders) the page is not prevented from entering
> the page cache. It was the check in DocumentLoader, which sets the main

But perhaps there are resources pending that _should_ stop this page from going to the cache that are not showing up in m_subresourceLoaders?

> > Shouldn't you somehow trigger loads for missing images after you restore
> > the page from the cache?
> 
> If the object is to return the user back to the state they were in, no. If the
> object is to return the user back to a working page no matter the change,
> then yes. This still feels like a policy decision. For back/forward loads we
> already have what used to be called "AllowStale" policy. That didn't make
> sense for the PageCache, because pages in incomplete states would never
> have been cached.

Without restarting the image loads you will get inconsistent behavior. In some cases hitting back will load the complete document (in case the page was not in the cache), in others the user will need to manually get the images by reloading. User doesn't know about the b/f cache so she won't know why this is.

Restarting the image loads shouldn't slow down the cache restore at all, but it would avoid the need to manually reload.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.