[Webkit-unassigned] [Bug 49838] Image Subresource Loads Should Not Prevent Page Cache Entry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49838





--- Comment #18 from Joseph Pecoraro <joepeck at webkit.org>  2010-12-08 16:32:55 PST ---
(In reply to comment #17)
> This patch should also check the pending resources in the documents
> CachedResourceLoader. The subresource list in the DocumentLoader is not
> reliable (In case multiple documents load the same resource in parallel, only
> one of the subresource lists has the resource. On the other hand some resource
> types are loaded using SubresourceLoaders directly and don't show up in the
> CachedResourceLoader. Yeah, it is a mess.) 

That is very good to know! However, in those cases (where the loaders do not
show up in m_subresourceLoaders) the page is not prevented from entering
the page cache. It was the check in DocumentLoader, which sets the main
document error to a cancellation as a result of m_subresourceLoaders not
being empty, that I saw prevent the page from being cached. Maybe that is
indicative of a separate problem that some subresource loads are ignored?


> Shouldn't you somehow trigger loads for missing images after you restore
> the page from the cache?

If the object is to return the user back to the state they were in, no. If the
object is to return the user back to a working page no matter the change,
then yes. This still feels like a policy decision. For back/forward loads we
already have what used to be called "AllowStale" policy. That didn't make
sense for the PageCache, because pages in incomplete states would never
have been cached.


> This is significant browser behavior change so maybe it should be a setting?

Good point. I had mentioned a compile flag in comment #8, but a setting makes
a lot of sense.

Thanks for the comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.