[Webkit-unassigned] [Bug 50644] [Qt] tagging network replies created by webkit with useful information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50644





--- Comment #3 from Peter Hartmann <peter.hartmann at nokia.com>  2010-12-08 05:41:13 PST ---
(In reply to comment #2)
> I think we should avoid using QNetworkRequest::attribute(). Attributes are already the fallback option to put stuff and got really messy over time.
> 
> What about QString QNetworkRequest::requestOriginType()? The strings give us infinite flexibility when releasing WebKit, and would not tie QtNetwork to WebKit related type of work.

I think a new QNetworkRequest::Attribute value would be the right place for this, to avoid adding a new method in QNetworkRequest. Then we could still decide whether we want this public (+ documented), undocumented or as a user value (the last option is probably a bad idea).

The benefit of QNetworkRequest::Attribute that I see is that if this is just a Webkit-only use case, we don't need to document the value for the new Attribute enum.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.