[Webkit-unassigned] [Bug 50566] Delay starting geolocation request until permission has been granted or denied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50566





--- Comment #3 from John Knottenbelt <jknotten at chromium.org>  2010-12-06 08:21:45 PST ---
(From update of attachment 75687)
View in context: https://bugs.webkit.org/attachment.cgi?id=75687&action=review

>> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:1
>> +description("Tests that when the timeout is 0, no callbacks are invoked until permission is denied. " +
> 
> Should probably name the test to reflect that it's specific to PREEMPT_GEOLOCATION_PERMISSION

Renamed to preempt-permission-timeout.html

>> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:3
>> +            "USED(CLIENT_BASED_GEOLOCATION)");
> 
> Don't mention CLIENT_BASED_GEOLOCATION - it'll go away and we don't want to have to update the test.

Ok.

>> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:28
>> +    debug('error was ' + e.code + ':  ' + e.message);
> 
> Probably no need for this.

Removed.

>> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:35
>> +window.setTimeout(denyPermission, 100);
> 
> Do you need a delay of 100ms? It's best not to make tests rely on such magic numbers.

Timer was not important to the test. Removed. Thanks for the suggestion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.