[Webkit-unassigned] [Bug 50566] Delay starting geolocation request until permission has been granted or denied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50566





--- Comment #2 from Steve Block <steveblock at google.com>  2010-12-06 06:51:21 PST ---
(From update of attachment 75687)
View in context: https://bugs.webkit.org/attachment.cgi?id=75687&action=review

You're right that this change is required to meet the exact wording of the spec, though I'm not sure that this is intentionally the case! Is there particular motivation for this change?

See Bug 42068 for background for PREEMPT_GEOLOCATION_PERMISSION

> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:1
> +description("Tests that when the timeout is 0, no callbacks are invoked until permission is denied. " +

Should probably name the test to reflect that it's specific to PREEMPT_GEOLOCATION_PERMISSION

> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:3
> +            "USED(CLIENT_BASED_GEOLOCATION)");

Don't mention CLIENT_BASED_GEOLOCATION - it'll go away and we don't want to have to update the test.

> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:28
> +    debug('error was ' + e.code + ':  ' + e.message);

Probably no need for this.

> LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-timeout.js:35
> +window.setTimeout(denyPermission, 100);

Do you need a delay of 100ms? It's best not to make tests rely on such magic numbers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.