[Webkit-unassigned] [Bug 50380] Implement "required" attribute for select tags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50380





--- Comment #16 from Kent Tamura <tkent at chromium.org>  2010-12-05 18:31:02 PST ---
(In reply to comment #9)
> >> WebCore/html/HTMLSelectElement.h:48
> >> +    bool isValidValue(const String& candidate) const { return !valueMissing(candidate); }
> > 
> > isValidValue() is not used.  We don't need to add it.
> > So, the parameter of valueMissing() is not needed.  It's always this->value().
> 
> Removed. It followed HTMLInputElement and HTMLTextAreaElement. Isn't it required? It looks a kind of inconsistent.
> HTMLTextAreaElement::isValidValue() looks not called. (It is called from WebKit/chromium as for HTMLInputElement.)

isValidValue() was introduced in orde that browsers can set valid values by their auto-fill / completion features.  Setting valid value to <select> is easy because it's just setting an index, and checking a string value doesn't make much sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.