[Webkit-unassigned] [Bug 50380] Implement "required" attribute for select tags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 5 18:27:00 PST 2010


--- Comment #15 from Kent Tamura <tkent at chromium.org>  2010-12-05 18:27:00 PST ---
(In reply to comment #10)
> >>> WebCore/html/HTMLSelectElement.cpp:115
> >>> +    if (!isRequiredFormControl() || disabled() || multiple() || size() > 1)
> >> 
> >> We don't need to check disabled() here.  It's responsibility of willValidate().

> wilValidate() is checked at checkValidity(), but not checked when directly reading properties validity.*. So it is required to check disable() (or willValidate()) here.

Oh, your understanding of the current code is correct.
I found the current code is wrong.  If willValidate is false, ValidityState::valueMissing() should return false and we should not call HTMLSelectElement::valueMissing().  Each of exposed functions of ValidityState should check willValidate() at their beginning like ValidityState::validationMessage() is doing.
Would you fix ValidityState::valueMissing() in this bug, and fix other functions of ValidityState in another bug please?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list