[Webkit-unassigned] [Bug 44914] [chromium] Add an interface for platform copy/paste drag/drop data objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44914


Daniel Cheng <dcheng at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65985|0                           |1
        is obsolete|                            |
  Attachment #65989|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Daniel Cheng <dcheng at chromium.org>  2010-08-30 18:10:00 PST ---
Created an attachment (id=65989)
 --> (https://bugs.webkit.org/attachment.cgi?id=65989)
Patch

(In reply to comment #2)
> (From update of attachment 65985 [details])
> > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> > +        [chromium] Add an interface for platform copy/paste drag/drop data objects
> > +        https://bugs.webkit.org/show_bug.cgi?id=44914
> 
> Nit: Please add a sentence explaining the general goal (ie., something about so we can eventually support arbitrary data types).

Done. Updating the other patch as well.

> 
> > diff --git a/WebCore/platform/chromium/ChromiumDataObjectNew.h b/WebCore/platform/chromium/ChromiumDataObjectNew.h
> > +    virtual String getData(const String& type, bool& succeeded) const = 0;
> > +    virtual bool setData(const String& type, const String& data) = 0;
> 
> It seems like these methods should use the same style.  Two possibilities: both return a bool (on success) or just remove the bool param complete from getdata (do we need to differentiate between empty and fail?).  The other getters below don't seem to use a bool.

This is inherited from Clipboard's getData() / setData() signature. I agree it's not ideal, but I don't feel comfortable changing Clipboard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.