[Webkit-unassigned] [Bug 44914] [chromium] Add an interface for platform copy/paste drag/drop data objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44914


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65985|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Tony Chang <tony at chromium.org>  2010-08-30 18:03:38 PST ---
(From update of attachment 65985)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +        [chromium] Add an interface for platform copy/paste drag/drop data objects
> +        https://bugs.webkit.org/show_bug.cgi?id=44914

Nit: Please add a sentence explaining the general goal (ie., something about so we can eventually support arbitrary data types).

> diff --git a/WebCore/platform/chromium/ChromiumDataObjectNew.h b/WebCore/platform/chromium/ChromiumDataObjectNew.h
> +    virtual String getData(const String& type, bool& succeeded) const = 0;
> +    virtual bool setData(const String& type, const String& data) = 0;

It seems like these methods should use the same style.  Two possibilities: both return a bool (on success) or just remove the bool param complete from getdata (do we need to differentiate between empty and fail?).  The other getters below don't seem to use a bool.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.