[Webkit-unassigned] [Bug 20471] Crash when dragging text in Google Docs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20471





--- Comment #11 from Enrica Casucci <enrica at apple.com>  2010-08-29 17:52:34 PST ---
(In reply to comment #10)
> (From update of attachment 65775 [details])
> WebCore/editing/ReplaceSelectionCommand.cpp:1000
>  +              RefPtr<Node>placeholder = createBreakElement(document());
> Need a space after the ">".
>
Sorry, this is a leftover from a previous version where I was keeping placeholder to remove it later, but it wasn't necessary. I've changed the code as you suggested.

> WebCore/editing/ReplaceSelectionCommand.cpp:1001
>  +              insertNodeBefore(placeholder, refNode.get());
> This could be placeholder.release() to avoid a tiny bit of reference count churn.
> 
> Or you could just put the createBreakElement function call right into the insertNodeBefore function call, which would also fix both of the above issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.