[Webkit-unassigned] [Bug 20471] Crash when dragging text in Google Docs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 18:35:24 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=20471





--- Comment #10 from Darin Adler <darin at apple.com>  2010-08-27 18:35:24 PST ---
(From update of attachment 65775)
WebCore/editing/ReplaceSelectionCommand.cpp:1000
 +              RefPtr<Node>placeholder = createBreakElement(document());
Need a space after the ">".

WebCore/editing/ReplaceSelectionCommand.cpp:1001
 +              insertNodeBefore(placeholder, refNode.get());
This could be placeholder.release() to avoid a tiny bit of reference count churn.

Or you could just put the createBreakElement function call right into the insertNodeBefore function call, which would also fix both of the above issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list