[Webkit-unassigned] [Bug 44728] Adopt more uses OwnPtr/OwnArray in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44728





--- Comment #4 from Sam Weinig <sam at webkit.org>  2010-08-26 18:34:20 PST ---
(In reply to comment #3)
> (From update of attachment 65636 [details])
> > -    for (size_t i = 0; i < m_size; ++i)
> > -        m_entries[i]->ref();
> 
> You got rid of the ref() here. That is not right, is it?

It is.  I commented in the changelog that I change the semantics of this function to match the adopt function. It is currently unused.

> Should this be an array of RefPtr<APIObject>?

It can't be if we want to allow the adoption semantics to remain the same (the C API is allowed to give a buffer that is adopted by the Array).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.