[Webkit-unassigned] [Bug 44728] Adopt more uses OwnPtr/OwnArray in WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 17:48:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44728


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65636|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2010-08-26 17:48:25 PST ---
(From update of attachment 65636)
> -    for (size_t i = 0; i < m_size; ++i)
> -        m_entries[i]->ref();

You got rid of the ref() here. That is not right, is it?

Should this be an array of RefPtr<APIObject>?

r=me as long as you fix that ref thing

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list