[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539





--- Comment #37 from Dawit A. <adawit at kde.org>  2010-08-22 00:59:14 PST ---
(In reply to comment #36)
> (From update of attachment 65046 [details])
> >WebCore/plugins/PluginDebug.cpp:171
> > +      default: return "Unkown variable";
> Spelling mistake, should be "Unknown variable".
> 
> >WebCore/plugins/PluginView.cpp:1387
> > +      if (platformGetValueForURL(variable, url, value, len, &result) || (result != NPERR_NO_ERROR))
> The " || (result != NPERR_NO_ERROR)" is not needed since platformGetValueForURL() returns true after setting either result code.

For the record I did that because it did not feel right to return true while setting an error from platformGetValueForURL, but I realized
afterwards that the return value from these "platform" functions is to indicate whether or not the request got handled ; not to indicate
an error condition occurred. Anyhow, fixed...

> >WebCore/plugins/PluginView.cpp:1401
> > +                  } else {
> Coding style, should be "} else"

No clue why that would be seen as good coding practise in the first place, but whatever. One can easily
shoot oneself in the foot in a deep nested if/else statement while following that practise. Still fixed.

> >WebCore/plugins/PluginView.cpp:1416
> > +          LOG(Plugins, "PluginView::getValueForURL(%s): Unknown variable type.", prettyNameForNPNURLVariable(variable).data());
> This will log "PluginView::getValueForURL(Unknown variable): Unknown variable type." which isn't very helpful.

Yes, that is indeed useless. Fixed.

I will post the final patch... Java applet support should work fine in QtWebKit once this patch gets accepted...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.