[Webkit-unassigned] [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539





--- Comment #36 from Andreas Kling <andreas.kling at nokia.com>  2010-08-21 21:35:30 PST ---
(From update of attachment 65046)
>WebCore/plugins/PluginDebug.cpp:171
> +      default: return "Unkown variable";
Spelling mistake, should be "Unknown variable".

>WebCore/plugins/PluginView.cpp:1387
> +      if (platformGetValueForURL(variable, url, value, len, &result) || (result != NPERR_NO_ERROR))
The " || (result != NPERR_NO_ERROR)" is not needed since platformGetValueForURL() returns true after setting either result code.

>WebCore/plugins/PluginView.cpp:1401
> +                  } else {
Coding style, should be "} else"

>WebCore/plugins/PluginView.cpp:1405
> +          } else {
Ditto.

>WebCore/plugins/PluginView.cpp:1416
> +          LOG(Plugins, "PluginView::getValueForURL(%s): Unknown variable type.", prettyNameForNPNURLVariable(variable).data());
This will log "PluginView::getValueForURL(Unknown variable): Unknown variable type." which isn't very helpful.


>WebCore/plugins/PluginView.cpp:1429
> +      if (platformSetValueForURL(variable, url, value, len, &result) || (result != NPERR_GENERIC_ERROR))
Same as above. platformSetValueForURL() should return true if it sets any result code IMO.

>WebCore/plugins/PluginView.cpp:1440
> +          } else {
Coding style, should be "} else"

>WebCore/plugins/PluginView.cpp:1461
> +      if (platformGetAuthenticationInfo(protocol, host, port, scheme, realm, username, ulen, password, plen, &result) || (result != NPERR_GENERIC_ERROR))
Same comment as earlier about the superfluous " || (result != NPERR_GENERIC_ERROR)"

>WebCore/plugins/qt/PluginViewQt.cpp:762
> +          } else {
Coding style, should be "} else"

Overall though, it's starting to look pretty good. I'll let an authorized reviewer take it from here. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.