[Webkit-unassigned] [Bug 39474] [GStreamer] GTK XOverlay support in GStreamerGWorld

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 19 00:47:39 PDT 2010


--- Comment #38 from Philippe Normand <pnormand at igalia.com>  2010-08-19 00:47:39 PST ---
(In reply to comment #37)
> (From update of attachment 64717 [details])
> WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h:46
>  +          gulong m_videoWindowId;
> Is gulong portable enough? Should we use a typedef similar to the PlatformWindowType here?

I believe gulong is fine. This is what gst_x_overlay_set_xwindow_id() requires anyway.

On Mac OS X it will be a cast of a NSView pointer and on Windows a cast of a HWND variable. I think it'd be fine to have those casts in the platform-specific implementations.

I adressed the last requested changes. I also cleaned up the signal and g_source callbacks in the controller to avoid the casts, thanks to the wise help of Martin.

Will land the patch, thanks for the long-standing review ;)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list