[Webkit-unassigned] [Bug 39474] [GStreamer] GTK XOverlay support in GStreamerGWorld

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39474


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64717|review?                     |review+
               Flag|                            |




--- Comment #37 from Gustavo Noronha (kov) <gns at gnome.org>  2010-08-18 15:40:17 PST ---
(From update of attachment 64717)
WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h:46
 +          gulong m_videoWindowId;
Is gulong portable enough? Should we use a typedef similar to the PlatformWindowType here?

 418     void webkit_web_view_enter_fullscreen(WebKitWebView* webView, WebCore::Node* node);
 419     void webkit_web_view_exit_fullscreen(WebKitWebView* webView);

Make these follow the standard WebKit naming, since they are not really API, I think. webkitWebViewEnterFullscreen, for instance.

WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:298
 +  
Needless empty line.

WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:590
 +  
One more needless empty line =).

Looks good to me, thanks for clarifying the GClosure point, btw, let's get this thing on the wild!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.