[Webkit-unassigned] [Bug 43449] [chromium] Generate drag images for HTML elements and selections.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43449





--- Comment #31 from Daniel Cheng <dcheng at chromium.org>  2010-08-18 14:45:24 PST ---
(In reply to comment #30)
> (From update of attachment 64773 [details])
> WebCore/page/chromium/FrameChromium.cpp:88
>  +      m_doc->updateLayout();
> Why do we need to call updateLayout a second time?

I don't honestly know, but this is what FrameMac.mm does in selectionImage and snapshotDragImage.

> 
> WebCore/page/chromium/FrameChromium.cpp:86
>  +      // Restore original state.
> Why wouldn't this save/restore just be part of your RAII?
> (The answer is because you use your RAII in two places, I guess.)
> 

It could. I guess it's easier to just make it capture the superset of state that both functions care about.

> WebCore/page/chromium/FrameChromium.cpp:66
>  +      const ScopedViewState state(m_view);
> This will end up restoring after the return statement (which is fine).  Just pointing out that its at a slightly different time than your previous patch.

Oops. That is probably a mistake...

> 
> WebCore/page/chromium/FrameChromium.cpp:120
>  +      m_doc->updateLayout();
> manual layout updates are rarely needed.  Why is this needed here?

See above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.