[Webkit-unassigned] [Bug 43449] [chromium] Generate drag images for HTML elements and selections.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43449





--- Comment #30 from Eric Seidel <eric at webkit.org>  2010-08-18 14:36:59 PST ---
(From update of attachment 64773)
WebCore/page/chromium/FrameChromium.cpp:88
 +      m_doc->updateLayout();
Why do we need to call updateLayout a second time?

WebCore/page/chromium/FrameChromium.cpp:86
 +      // Restore original state.
Why wouldn't this save/restore just be part of your RAII?
(The answer is because you use your RAII in two places, I guess.)

WebCore/page/chromium/FrameChromium.cpp:66
 +      const ScopedViewState state(m_view);
This will end up restoring after the return statement (which is fine).  Just pointing out that its at a slightly different time than your previous patch.

WebCore/page/chromium/FrameChromium.cpp:120
 +      m_doc->updateLayout();
manual layout updates are rarely needed.  Why is this needed here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.