[Webkit-unassigned] [Bug 43999] Support JSVALUE32_64 on MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43999





--- Comment #5 from Chao-ying Fu <fu at mips.com>  2010-08-16 11:00:32 PST ---
(In reply to comment #4)
> The patch looks good to me, but I have some questions.
> 
> >      struct JITStackFrame {
> >          void* reserved; // Unused
> > +#if USE(JSVALUE32_64)
> > +        void* padding1; // Maintain 8-byte stack alignment.
> > +#endif
> 
> You could switch the type of 'reserved' member to JITStubArg which is a 32 bits wide data if JSVALUE32 is enabled, and 64 bits wide otherwise. So the alignment of the 'args' should be fine in both cases.

  Yes, this is a good idea.  I can use JITStubArg to avoid padding1.

> 
> >          JITStubArg args[6];
> >  
> > +#if USE(JSVALUE32_64)
> > +        void* padding2; // Maintain 8-byte stack alignment.
> > +#endif
> > +
> 
> I do not get why it is needed. If 'args' member is aligned, the preservedGP is aligned too.

  Yes, preservedGP is already aligned.  But I need padding2, so that the overall stack length can be a multiple of 8 bytes.  MIPS O32 ABI requires this.

> 
> >          void* preservedGP; // store GP when using PIC code
> >          void* preservedS0;

  Thanks!

Regards,
Chao-ying

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.